ManageIQ provides developers with convenient methods for quickly setting up virtual machines. For example, to add memory, it is enough to call the set_memory method on the VM. However, we found several problems when working on the VMware platform: the add_disk method does not allow you to specify the disk connection address and cannot create a controller, and the resize_disk method does not work at all.
There are few methods for quickly setting up a VM, and they have both their advantages and disadvantages.
Resizing a disk
It turned out that everything was simple with the non-working resize_disk method. When calling this method, error messages appear in the logs:
ERROR -- evm: Q-task_id([r1000000000784_service_reconfigure_task_1000000000784]) [NameError]: undefined local variable or method 'device' for #<MiqVimVm:...>
...
ERROR -- evm: Q-task_id([r1000000000784_service_reconfigure_task_1000000000784]) /opt/manageiq/manageiq-gemset/gems/vmware_web_service-3.2.0/lib/VMwareWebService/MiqVimVm.rb:873:in 'resizeDisk'That is, in the resizeDisk method there is a syntax error (MiqVimVm.rb, line 873): undefined variable device (insufficient code coverage by tests). Apparently, the variable disk was meant, you just need to fix it:
# in the resizeDisk method you need to comment out the line or replace it in the line
logger.debug "MiqVimVm::resizeDisk: backingFile = #{backingFile} current size = #{device.capacityInKB} newSize = #{newSizeInKb} KB"
# device.capacityInKB на disk.capacityInKB
logger.debug "MiqVimVm::resizeDisk: backingFile = #{backingFile} current size = #{disk.capacityInKB} newSize = #{newSizeInKb} KB"Adding a disk
The new disk is created successfully, but it will not be possible to connect it to a specific SCSI address, there is no such functionality. The choice of the disk connection location is made in line 757 of the same MiqVimVm.rb file. The available_scsi_units method returns a list of available SCSI addresses and the very first one is taken from this list. This script needs to be modified.
# replace the line for selecting the first free unit
ck, un = available_scsi_units.first
# with the line
ck, un = options[:location].present? ? getScsiUnits(options[:location]) : available_scsi_units.first
And add new methods:
#
# Find a SCSI controller by disk location and
# return its key and disk unit_number.
#
def getScsiUnits(location)
scsi_bus, disk_unit_number = location.split(':')
scsi_controller = getOrCreateScsiController(scsi_bus)
[scsi_controller["key"].to_i, disk_unit_number.to_i]
end
#
# Find a SCSI controller by SCSI bus number and return it.
#
def getScsiControllerByBusNumber(scsi_bus)
hardware ||= getHardware
getScsiControllers(hardware).find { |sk| sk["busNumber"] == scsi_bus }
end
#
# Find or create SCSI controller by SCSI bus number and return it.
#
def getOrCreateScsiController(scsi_bus)
scsi_controller = getScsiControllerByBusNumber(scsi_bus)
if scsi_controller.nil?
addScsiController(scsi_bus)
scsi_controller = getScsiControllerByBusNumber(scsi_bus)
end
raise "getOrCreateScsiController: no SCSI controller found" if scsi_controller.nil?
scsi_controller
end
#
# Create a new SCSI controller.
#
def addScsiController(bus_number = 1, device_type = 'ParaVirtualSCSIController')
logger.info "MiqVimVm::addScsiController: device_type = #{device_type} bus_number = #{bus_number}"
vmConfigSpec = VimHash.new("VirtualMachineConfigSpec") do |vmcs|
vmcs.deviceChange = VimArray.new("ArrayOfVirtualDeviceConfigSpec") do |vmcs_vca|
vmcs_vca << VimHash.new("VirtualDeviceConfigSpec") do |vdcs|
vdcs.operation = VirtualDeviceConfigSpecOperation::Add
vdcs.device = VimHash.new(device_type) do |dev|
dev.sharedBus = VimString.new('noSharing', 'VirtualSCSISharing')
dev.busNumber = bus_number
dev.key = -101
end
end
end
end
logger.info "MiqVimVm(#{@invObj.server}, #{@invObj.username}).addScsiController: calling reconfigVM_Task"
taskMor = @invObj.reconfigVM_Task(@vmMor, vmConfigSpec)
logger.info "MiqVimVm(#{@invObj.server}, #{@invObj.username}).addScsiController: returned from reconfigVM_Task"
waitForTask(taskMor)
end
All that remains is to ensure that the location parameter is passed to the addDisk method. The problem is that the list of parameters to be passed is specifically limited, it is not entirely clear why this was done, but we will adhere to the same approach as the developers:
In the file /opt/manageiq/manageiq-gemset/bundler/gems/manageiq-providers-vmware-*/app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/operations/configuration.rb, you need to add the passing of the location parameter in the call to the run_command_via_parent method in raw_add_disk:
def raw_add_disk(disk_name, disk_size_mb, options = {})
...
run_command_via_parent(:vm_add_disk, :diskName => disk_name, :diskSize => disk_size_mb,
:thinProvisioned => options[:thin_provisioned], :dependent => options[:dependent],
:persistent => options[:persistent], :bootable => options[:bootable], :datastore => datastore,
:interface => options[:interface], :location => options[:location])
end
And in the file /opt/manageiq/manageiq-gemset/bundler/gems/manageiq-providers-vmware-*/app/models/manageiq/providers/vmware/infra_manager.rb add passing the location parameter in the call to invoke_vim_ws in the vm_add_disk method:
def vm_add_disk(vm, options = {})
invoke_vim_ws(:addDisk, vm, options[:user_event], options[:diskName], options[:diskSize], nil, nil,
:thin_provisioned => options[:thinProvisioned], :dependent => options[:dependent],
:persistent => options[:persistent], :location => options[:location])
end
Please note: Making changes to the source code will require a server restart to apply them, and you will also need to re-make these changes to the code after each MIQ update.
Files to the article
manageiq-vm-disks2.zip – full code of all modified scripts